Re: [PATCH 2/2] bcache: add undef for macro in function

From: Coly Li
Date: Tue Aug 14 2018 - 09:28:17 EST


On 2018/8/14 4:16 PM, Dongbo Cao wrote:
> add undef for macro d_strtoul,d_strtoul_nonzero and d_strtoi_h
>
> Signed-off-by: Dongbo Cao <cdbdyx@xxxxxxx>
> ---
> drivers/md/bcache/sysfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index 225b15aa..ed67a290 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -349,6 +349,9 @@ STORE(__cached_dev)
> if (attr == &sysfs_stop)
> bcache_device_stop(&dc->disk);
>
> +#undef d_strtoul
> +#undef d_strtoul_nonzero
> +#undef d_strtoi_h
> return size;
> }
>
>

Hi Dongbo,

Could you please to provide the motivation why you make this change ?

Thanks.

Coly Li