Re: [PATCH v2] perf tools: Check for null when copying nsinfo.

From: Arnaldo Carvalho de Melo
Date: Mon Aug 13 2018 - 14:39:53 EST


Em Fri, Aug 10, 2018 at 03:36:13PM +0200, Benno Evers escreveu:
> The argument to nsinfo__copy() was assumed to be valid, but some code paths
> exist that will lead to NULL being passed.
>
> In particular, running 'perf script -D' on a perf.data file containing an
> PERF_RECORD_MMAP event associating the '[vdso]' dso with pid 0 earlier in
> the event stream will lead to a segfault.
>
> Since all calling code is already checking for a non-null return value,
> just return NULL for this case as well.
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> Signed-off-by: Benno Evers <bevers@xxxxxxxxxxxxxx>

Thanks, applied.

- Arnaldo