Re: [PATCH v2] xen-netfront: fix warn message as irq device name has '/'

From: David Miller
Date: Mon Aug 13 2018 - 11:52:05 EST


From: Xiao Liang <xiliang@xxxxxxxxxx>
Date: Sat, 11 Aug 2018 23:21:37 +0800

> There is a call trace generated after commit 2d408c0d4574b01b9ed45e02516888bf925e11a9(
> xen-netfront: fix queue name setting). There is no 'device/vif/xx-q0-tx' file found
> under /proc/irq/xx/.
>
> This patch only picks up device type and id as its name.

This adds a compile warning:

drivers/net/xen-netfront.c: In function ʽxennet_init_queueʼ:
drivers/net/xen-netfront.c:1614:2: warning: ignoring return value of ʽkstrtointʼ, declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(strrchr(queue->info->xbdev->nodename, '/') + 1, 10, &devid);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~