Re: [PATCH v3 16/17] driver/edac: enable Hygon support to AMD64 EDAC driver

From: Michael Jin
Date: Sat Aug 11 2018 - 16:10:55 EST


On Sat, Aug 11, 2018 at 3:56 PM, Michael Jin <mikhail.jin@xxxxxxxxx> wrote:
> On Sat, Aug 11, 2018 at 9:30 AM, Pu Wen <puwen@xxxxxxxx> wrote:
>> @@ -1051,6 +1065,16 @@ static void determine_memory_type(struct amd64_pvt *pvt)
>> else
>> pvt->dram_type = MEM_DDR4;
>> return;
>> + case 0x18:
>> + if (pvt->vendor == X86_VENDOR_HYGON) {
>
> This vendor checking is not necessary as there are no other known
> family 18h processors.

Actually, vendor checking works here. Although, AMD has not released a
family 18h yet.