Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

From: Stephen Boyd
Date: Thu Aug 09 2018 - 19:31:03 EST


Quoting Julius Werner (2018-08-09 11:10:42)
> > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void __iomem *ptr)
> > ptr_entry += entry.size;
> > }
> >
> > - if (ret)
> > + if (ret) {
> > + bus_unregister(&coreboot_bus_type);
> > iounmap(ptr);
> > + }
>
> nit: maybe cleaner to just do if (ret) coreboot_table_exit(); here?
> You're essentially writing the same code again.

Ok.