Re: [PATCH] drm/panel: simple: fix -Wliteral-conversion warning

[Nick Desaulniers]

On Thu, Aug 9, 2018 at 3:00 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
>
> On Fri, Jun 15, 2018 at 03:37:49PM -0700, Nick Desaulniers wrote:
> > Fixes commit 8cfe83419cdb ("drm/panel: simple: Add
> > support for KEO TX31D200VM0BAA")
> >
> > drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from
> >       'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
> >       [-Wliteral-conversion]
> >         .vfront_porch = { 6, 21, 33.5 },
> >                         ~        ^~~~
> > drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from
> >       'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33
> >       [-Wliteral-conversion]
> >         .vback_porch = { 6, 21, 33.5 },
> >                        ~        ^~~~
> >
> > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> > ---
> > Alternatively, should these be rounded up to 34?  I'm guessing the
> > current behaviour (truncation) is correct since that's how the patch was
> > operating.
>
> Looks like this is a duplicate of what was merged as:
>
> commit c9b6be7dc13e2f87592ee4c9812cb450dba484d5
> Author: Stefan Agner <stefan@xxxxxxxx>
> Date:   Thu Apr 19 23:20:03 2018 +0200

Ah, cool.  I need to be better about checking maintainers' trees.

Just curious, how come a patch from April hasn't hit torvalds/linux yet?
-- 
Thanks,
~Nick Desaulniers