Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

From: Pavel Machek
Date: Wed Aug 08 2018 - 18:00:19 EST


On Tue 2018-08-07 11:04:41, Dan Murphy wrote:
> Add the device tree bindings for the lm3697
> led driver for backlighting and display.

What I'd like to see:

> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
> new file mode 100644
> index 000000000000..7b8e490f1ea1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
> @@ -0,0 +1,64 @@
> +* Texas Instruments - LM3697 Highly Efficient White LED Driver
> +
> +The LM3697 11-bit LED driver provides high-
> +performance backlight dimming for 1, 2, or 3 series
> +LED strings while delivering up to 90% efficiency.
> +
> +This device is suitable for Display and Keypad Lighting
> +
> +Required properties:
> + - compatible:
> + "ti,lm3967"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> + - control-bank-cfg - : Indicates which sink is connected to which control bank
> + 0 - All HVLED outputs are controlled by bank A
> + 1 - HVLED1 is controlled bank B, HVLED2/3 are controlled by bank A
> + 2 - HVLED2 is controlled bank B, HVLED1/3 are controlled by bank A
> + 3 - HVLED1/2 are controlled by bank B, HVLED3 is controlled by bank A
> + 4 - HVLED3 is controlled by bank B, HVLED1/2 are controlled by bank A
> + 5 - HVLED1/3 is controlled by bank B, HVLED2 is controlled by bank A
> + 6 - (default) HVLED1 is controlled by bank A, HVLED2/3 are controlled by bank B
> + 7 - All HVLED outputs are controlled by bank B

Remove control-bank-cfg.

> +Optional properties:
> + - enable-gpios : gpio pin to enable/disable the device.
> + - vled-supply : LED supply
> +
> +Required child properties:
> + - reg : 0 - LED is Controlled by bank A
> + 1 - LED is Controlled by bank B

Add required child property:
- hvleds = <list> -- set of outputs this child controls.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature