Re: [PATCH v2 08/18] serial: intel: Get serial id from dts

[Wu, Songjun]

On 8/3/2018 1:43 PM, Greg Kroah-Hartman wrote:
> On Fri, Aug 03, 2018 at 11:02:27AM +0800, Songjun Wu wrote:
> > Get serial id from dts.
> >
> > "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC
> > macro is defined in lantiq_soc.h.
> > lantiq_soc.h is in arch path for legacy product support.
> >
> > arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
> >
> > If "#ifdef preprocessor" is changed to
> > "if (IS_ENABLED(CONFIG_LANTIQ))", when CONFIG_LANTIQ is not enabled,
> > code using LTQ_EARLY_ASC is compiled.
> > Compilation will fail for no LTQ_EARLY_ASC defined.
> >
> > Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v2: None
> >
> >   drivers/tty/serial/lantiq.c | 19 +++++++++++++++----
> >   1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
> > index 044128277248..836ca51460f2 100644
> > --- a/drivers/tty/serial/lantiq.c
> > +++ b/drivers/tty/serial/lantiq.c
> > @@ -6,6 +6,7 @@
> >    * Copyright (C) 2007 Felix Fietkau <nbd@xxxxxxxxxxx>
> >    * Copyright (C) 2007 John Crispin <john@xxxxxxxxxxx>
> >    * Copyright (C) 2010 Thomas Langer, <thomas.langer@xxxxxxxxxx>
> > + * Copyright (C) 2018 Intel Corporation.
> Your changes here do not warrent the addition of a copyright line, don't
> you agree?  If not, please get a signed-off-by from your corporate
> lawyer who does this this is warrented when you resend this patch.
>
> thanks,
>
> greg k-h
Thanks.
The copyright line will be removed when we resend this patch.