Re: [PATCH] sched/fair: sync expires_seq in distribute_cfs_runtime()

From: Cong Wang
Date: Fri Aug 03 2018 - 17:55:25 EST


On Wed, Aug 1, 2018 at 10:17 AM <bsegall@xxxxxxxxxx> wrote:
> Yes, in practice what's actually going to happen is that the
> runtime_remaining will be put to 1 by distribute, the cfs_rq will be
> unthrottled, and then when it runs it will go negative immediately and
> hit the negative check in expires, so expires_seq being wrong will not
> actually matter. In addition, the worst thing that will happen if one of
> the account_cfs_rq_runtime(cfs_rq, 0) paths is hit first is that it will
> lose 1ns of quota, which also doesn't really matter.

Ah, I see.

Thanks!