[PATCH] misc: eeprom: assignment outside the if statement

From: Parth Y Shah
Date: Fri Aug 03 2018 - 05:20:54 EST


Assignment of any variable should be kept outside the if statement

Signed-off-by: Parth Y Shah <sparth1292@xxxxxxxxx>
---
drivers/misc/eeprom/max6875.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c
index 0e32709..fc0cf9a 100644
--- a/drivers/misc/eeprom/max6875.c
+++ b/drivers/misc/eeprom/max6875.c
@@ -148,7 +148,8 @@ static int max6875_probe(struct i2c_client *client,
if (client->addr & 1)
return -ENODEV;

- if (!(data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL)))
+ data = kzalloc(sizeof(struct max6875_data), GFP_KERNEL);
+ if (!data)
return -ENOMEM;

/* A fake client is created on the odd address */
--
2.7.4