Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr

From: Nick Desaulniers
Date: Thu Aug 02 2018 - 13:07:46 EST


On Wed, Aug 1, 2018 at 6:42 PM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Date: Wed, 1 Aug 2018 14:57:59 -0700
>
> > - sk, what, when, current_text_addr());
> > + sk, what, when, (void *)_THIS_IP_);
>
> Is a fugly macro in all caps really better than a function()?
>
> I'm really surprised that _THIS_IP_ is being chosen over
> current_text_addr(), seriously.

See: https://lkml.org/lkml/2018/8/1/1689

I'm happy to rename it on your suggestion, after we've consolidated them.

--
Thanks,
~Nick Desaulniers