Re: [PATCH v3 0/6] KVM: nVMX: Enlightened VMCS for Hyper-V on KVM

From: Vitaly Kuznetsov
Date: Thu Aug 02 2018 - 12:04:33 EST


Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:

> On 25/07/2018 18:30, Vitaly Kuznetsov wrote:
>> Changes since v2:
>> - Rebase to the current kvm/queue.
>> - Simplify clean fields check in prepare_vmcs02{,_full} and
>> copy_enlightened_to_vmcs12() by resetting the clean fields mask in
>> nested_vmx_handle_enlightened_vmptrld() when we switch from one L2 guest
>> to another [Paolo Bonzini]
>> - Cope with the newly introduced vmx_get_nested_state() by returning
>> -ENOTSUPP when eVMCS is in use. We'll do proper nested state save/restore
>> later.
>
> Looks good, but we have to do something about live migration.

Sure,

I don't actually see any fundumental problems when eVMCS is in use,
however, I'd like to enable migration when we know that it works so I
was going to wait for your nested virtualization state migration series
to land and gain Qemu support before starting to experiment. "One bite
at a time".

> Perhaps you can write a testcase analogous to the new state_test, that
> tests eVMCS in general before we have support in QEMU.

I'll take a look, thanks for the pointer!

--
Vitaly