Re: [PATCH 5/8] staging: gasket: core: add subsystem and device info to error logs

From: Greg Kroah-Hartman
Date: Thu Aug 02 2018 - 12:03:08 EST


On Thu, Aug 02, 2018 at 01:42:42AM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
>
> Identify gasket as the subsystem printing various error messages.
> Add the driver name to appropriate messages to indicate which driver
> has a problem.
>
> Signed-off-by: Todd Poynor <toddpoynor@xxxxxxxxxx>
> ---
> drivers/staging/gasket/gasket_core.c | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> index 36c077fffc41c..19331feb9b09f 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -160,7 +160,7 @@ static int gasket_find_dev_slot(struct gasket_internal_desc *internal_desc,
> for (i = 0; i < GASKET_DEV_MAX; i++) {
> if (internal_desc->devs[i] &&
> strcmp(internal_desc->devs[i]->kobj_name, kobj_name) == 0) {
> - pr_err("Duplicate device %s\n", kobj_name);
> + pr_err("gasket: Duplicate device %s\n", kobj_name);

same here with the prefix.

thanks,

greg k-h