Re: [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

From: Rob Herring
Date: Wed Aug 01 2018 - 18:20:44 EST


On Wed, Aug 1, 2018 at 2:57 AM Srinivas Kandagatla
<srinivas.kandagatla@xxxxxxxxxx> wrote:
>
> Thanks for the review.
>
> On 31/07/18 21:43, Rob Herring wrote:
> >> +
> >> +- reset-gpio:
> > reset-gpios
> >
> Yep, reset-gpios makes more inline with others!
> >> + Usage: required
> >> + Value type: <String Array>
> >> + Definition: Reset gpio line
> >> +
> >> +- qcom,ifd:
> >> + Usage: required
> >> + Value type: <phandle>
> >> + Definition: SLIM interface device
> > Wouldn't this be the parent?
> >
> No, Interface device is just like other slim device and is part of
> SLIMbus Component and has a unique address. Every SLIMbus component has
> one interface device.

I still don't understand what this means. If this is SLIMbus specific,
then maybe it should be named that way? Or it is QCom specific?

Rob