Hi John,
On Sat, 2018-07-28 at 15:53 -0400, John S Gruber wrote:
> The Redragon keyboard uses the second device being presented, but
> other
> devices with the same vendor_id/device_id pair (0x0c45:760b) use the
> first.
> Don't cause its deletion. Problem introduced in commit 85455dd906d5
> ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard")
>
> Fixes: 85455dd906d5
> Signed-off-by: John S Gruber <JohnSGruber@xxxxxxxxx>
> ---
>Â drivers/hid/hid-redragon.c | 4 ----
>Â 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/hid/hid-redragon.c b/drivers/hid/hid-redragon.c
> index daf5957..85a5fbb 100644
> --- a/drivers/hid/hid-redragon.c
> +++ b/drivers/hid/hid-redragon.c
> @@ -55,10 +55,6 @@ static int redragon_probe(struct hid_device *dev,
>Â Â Â Â Â Â Â Âreturn ret;
>Â Â Â Â}
>
> -Â Â Â/* do not register unused input device */
> -Â Â Âif (dev->maxapplication == 1)
> -Â Â Â Â Â Â Âreturn 0;
> -
>Â Â Â Âret = hid_hw_start(dev, HID_CONNECT_DEFAULT);
>Â Â Â Âif (ret) {
>Â Â Â Â Â Â Â Âhid_err(dev, "hw start failed\n");
As I mentioned, this is already fixed by
dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e, scheduled for 4.19, and I
suggest that we instead add that one to 4.18.
The explanation is that the block you deleted was the whole reason for
adding the redragon_probe function, so the changes are largely
equivalent.
Thanks,
Robert