Re: [PATCH] pwm: meson: fix mux clock names

From: Neil Armstrong
Date: Wed Aug 01 2018 - 06:59:37 EST


On 01/08/2018 12:57, Jerome Brunet wrote:
> Current clock name looks like this:
> /soc/bus@ffd00000/pwm@1b000#mux0
>
> This is bad because CCF uses the clock to create a directory in clk debugfs.
> With such name, the directory creation (silently) fails and the debugfs
> entry end up being created at the debugfs root.
>
> With this change, the clock name will now be:
> ffd1b000.pwm#mux0
>
> This matches the clock naming scheme used in the ethernet and mmc driver.
> It also fixes the problem with debugfs.
>
> Fixes: 36af66a79056 ("pwm: Convert to using %pOF instead of full_name")
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> ---
> drivers/pwm/pwm-meson.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 822860b4801a..c1ed641b3e26 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -458,7 +458,6 @@ static int meson_pwm_init_channels(struct meson_pwm *meson,
> struct meson_pwm_channel *channels)
> {
> struct device *dev = meson->chip.dev;
> - struct device_node *np = dev->of_node;
> struct clk_init_data init;
> unsigned int i;
> char name[255];
> @@ -467,7 +466,7 @@ static int meson_pwm_init_channels(struct meson_pwm *meson,
> for (i = 0; i < meson->chip.npwm; i++) {
> struct meson_pwm_channel *channel = &channels[i];
>
> - snprintf(name, sizeof(name), "%pOF#mux%u", np, i);
> + snprintf(name, sizeof(name), "%s#mux%u", dev_name(dev), i);
>
> init.name = name;
> init.ops = &clk_mux_ops;
>

Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>