Re: [PATCH v11 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

[Balakrishna Godavarthi]

Hi Matthias,

On 2018-07-31 00:07, Matthias Kaehlcke wrote:
> On Fri, Jul 27, 2018 at 07:43:16PM +0530, Balakrishna Godavarthi wrote:
> > From: Balakrishna Godavarthi <bgodavar@xxxxxxxxxxxxxx>
> >
> > Redefinition of qca_uart_setup will help future Qualcomm Bluetooth
> > SoC, to use the same function instead of duplicating the function.
> > Added new arguments soc_type and soc_ver to the functions.
> >
> > These arguments will help to decide type of firmware files
> > to be loaded into Bluetooth chip.
> > soc_type holds the Bluetooth chip connected to APPS processor.
> > soc_ver holds the Bluetooth chip version.
> >
> > Signed-off-by: Balakrishna Godavarthi <bgodavar@xxxxxxxxxxxxxx>
> > Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > ---
> > Changes in v11:
> >       * added error log in qca_read_soc_version() instead of 
> > qca_setup()
> > ---
> >  drivers/bluetooth/btqca.c   | 23 ++++++++++-------------
> >  drivers/bluetooth/btqca.h   | 13 +++++++++++--
> >  drivers/bluetooth/hci_qca.c | 10 +++++++++-
> >  3 files changed, 30 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index c5cf9cab438a..b2163bf75b95 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -85,6 +85,12 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 
> > *soc_version)
> >  out:
> >  	kfree_skb(skb);
> >
> > +	if (!err && *soc_version == 0)
> > +		err = -EILSEQ;
>
> nit: better do this right after assigning SoC version. No need to
> respin the series just for this though.

[Bala]: will update.

--
Regards
Balakrishna.