Re: [RFC PATCH net-next v2 10/17] ethtool: implement GET_SETTINGS message

From: Andrew Lunn
Date: Mon Jul 30 2018 - 15:09:45 EST


> +Response contents:
> +
> + ETHA_SETTINGS_LINK (u32) link state

> + [ETHA_SETTINGS_LINK] = { .type = NLA_FLAG },

Is this correct?

The link is either up or down. So a u32 seems a bit big.

Andrew