Re: [PATCH] stop_machine: Disable preemption after queueing stopper threads

From: Thomas Gleixner
Date: Mon Jul 30 2018 - 06:21:14 EST


On Tue, 24 Jul 2018, Sebastian Andrzej Siewior wrote:
> On 2018-07-23 18:13:48 [-0700], isaacm@xxxxxxxxxxxxxx wrote:
> > Hi all,
> Hi,
>
> > Are there any comments about this patch?
>
> I haven't look in detail at this but your new preempt_disable() makes
> things unbalanced for the err != 0 case.

It doesn't but that code is really an unreadable pile of ...