Re: [PATCH 04/10] x86,mm: use on_each_cpu_cond for TLB flushes

From: Andy Lutomirski
Date: Sat Jul 28 2018 - 22:59:09 EST


On Sat, Jul 28, 2018 at 2:53 PM, Rik van Riel <riel@xxxxxxxxxxx> wrote:
> Instead of open coding bitmap magic, use on_each_cpu_cond
> to determine which CPUs to send TLB flush IPIs to.
>
> This might be a little bit slower than examining the bitmaps,
> but it should be a lot easier to maintain in the long run.

Looks good.

i assume it's not easy to get the remove-tables case to do a single
on_each_cpu_cond() instead of two? Currently it's doing the lazy ones
and the non-lazy ones separately.