Re: [PATCH net-next 1/2] tcp: call tcp_drop() in tcp collapse

From: Eric Dumazet
Date: Fri Jul 27 2018 - 23:38:59 EST


On Fri, Jul 27, 2018 at 8:35 PM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:

> So what about LINUX_MIB_TCPOFOMERGE ?
> Regarding LINUX_MIB_TCPOFOMERGE, a skb is already covered by another
> skb, is that dropping the packet or simply lowering the memory
> overhead ?

What do you think ?

If you receive two times the same payload, don't you have to drop one
of the duplicate ?

There is a a big difference between the two cases.