Re: [PATCH] x86/mce: Handle varying MCA bank counts

From: Luck, Tony
Date: Fri Jul 27 2018 - 18:08:37 EST


On Fri, Jul 27, 2018 at 04:40:09PM -0500, Yazen Ghannam wrote:
> - /* Don't support asymmetric configurations today */
> - WARN_ON(mca_cfg.banks != 0 && b != mca_cfg.banks);
> - mca_cfg.banks = b;
> + mca_cfg.banks = max(mca_cfg.banks, b);

Should we change mca_cfg.banks to be a per-cpu variable?

DEFINE_PER_CPU(int, mce_num_banks);

That would make it easier to make sure the places
that scan all banks only look at the ones that exist.

-Tony