Re: [PATCH] f2fs: fix to restrict mount condition when without CONFIG_QUOTA

From: Jaegeuk Kim
Date: Fri Jul 27 2018 - 06:09:02 EST


On 07/25, Chao Yu wrote:
> From: Chao Yu <yuchao0@xxxxxxxxxx>
>
> Like quota_ino feature, we need to reject mounting RDWR with image
> which enables project_quota feature when there is no CONFIG_QUOTA
> be set in kernel.
>
> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
> ---
> fs/f2fs/super.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index dbc1cb53581f..bb40f08d2861 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -775,6 +775,12 @@ static int parse_options(struct super_block *sb, char *options)
> "without CONFIG_QUOTA");
> return -EINVAL;
> }
> + if (f2fs_sb_has_project_quota(sbi->sb) && !f2fs_readonly(sbi->sb)) {
> + ext4_msg(sb, KERN_ERR,

What is this?

> + "Filesystem with project quota feature cannot be "
> + "mounted RDWR without CONFIG_QUOTA");
> + return -EINVAL;
> + }
> #endif
>
> if (F2FS_IO_SIZE_BITS(sbi) && !test_opt(sbi, LFS)) {
> --
> 2.16.2.17.g38e79b1fd