Re: [PATCH v2] sched/numa: do not balance tasks onto isolated cpus

From: Peter Zijlstra
Date: Fri Jul 27 2018 - 03:48:57 EST


On Thu, Jul 26, 2018 at 04:19:08PM +0800, Cheng Lin wrote:
> - if (!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> + if ((!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> + || !housekeeping_test_cpu(arg.dst_cpu, HK_FLAG_DOMAIN))
> goto out;

You did not read the comment I provided last time. Using isolcpus (and
thus it's renamed houskeeping thing) is the wrong thing to do. Load
balancing should be limited to it's root domain.