Re: [PATCHv3 0/2] Stackleak for arm64

From: Will Deacon
Date: Thu Jul 26 2018 - 05:55:52 EST


Hi Laura,

On Wed, Jul 25, 2018 at 03:05:58PM -0700, Laura Abbott wrote:
> On 07/25/2018 04:49 AM, Will Deacon wrote:
> >arch/arm64/kernel/sdei.c: At top level:
> >arch/arm64/kernel/sdei.c:127:6: error: conflicting types for â_on_sdei_stackâ
> > bool _on_sdei_stack(unsigned long sp,
> > ^~~~~~~~~~~~~~
> >In file included from ./include/linux/arm_sdei.h:14:0,
> > from arch/arm64/kernel/sdei.c:5:
> >./arch/arm64/include/asm/sdei.h:45:6: note: previous declaration of â_on_sdei_stackâ was here
> > bool _on_sdei_stack(unsigned long sp, struct stack_info *info);
> > ^~~~~~~~~~~~~~
> >arch/arm64/kernel/sdei.c: In function â_on_sdei_stackâ:
> >arch/arm64/kernel/sdei.c:136:33: error: âinfoâ undeclared (first use in this function); did you mean âintâ?
> > if (on_sdei_critical_stack(sp, info))
> > ^~~~
> > int
> >arch/arm64/kernel/sdei.c:131:21: warning: unused variable âhighâ [-Wunused-variable]
> > unsigned long low, high;
> > ^~~~
> >arch/arm64/kernel/sdei.c:131:16: warning: unused variable âlowâ [-Wunused-variable]
> > unsigned long low, high;
> > ^~~
> >make[1]: *** [arch/arm64/kernel/sdei.o] Error 1
> >make[1]: *** Waiting for unfinished jobs....
> >make: *** [arch/arm64/kernel] Error 2
> >
>
> Ugh this was a failure that I missed folding in, sorry about that

That's ok, thanks for the quick fixup. I'll fold it in and push this out
later on.

Cheers,

Will