Re: [PATCH -next] fs/epoll: simply CONFIG_NET_RX_BUSY_POLL ifdefery

From: Andrew Morton
Date: Wed Jul 25 2018 - 17:30:51 EST


On Wed, 25 Jul 2018 13:06:33 -0700 Davidlohr Bueso <dave@xxxxxxxxxxxx> wrote:

> >> +#else
> >> +#define ep_busy_loop(ep, nonblock) do { } while (0)
> >> +#define ep_reset_busy_poll_napi_id(ep) do { } while (0)
> >> +#define ep_set_busy_poll_napi_id(epi) do { } while (0)
> >> +
> >> +#endif /* CONFIG_NET_RX_BUSY_POLL */
> >
> >inlines are preferred. Because macros are fugly and can cause
> >unused-var warnings when the stub versions are used.
>
> Fair enough.
>
> >This?
>
> Do you want me to send a v2 or will you fold in the below?

I queued both patches.