Re: [PATCH] KVM/MMU: Combine flushing remote tlb in mmu_set_spte()

From: Xiao Guangrong
Date: Wed Jul 25 2018 - 02:23:10 EST




On 07/24/2018 10:35 PM, Paolo Bonzini wrote:
On 24/07/2018 10:17, Tianyu Lan wrote:
mmu_set_spte() flushes remote tlbs for drop_parent_pte/drop_spte()
and set_spte() separately. This may introduce redundant flush. This
patch is to combine these flushes and check flush request after
calling set_spte().

Signed-off-by: Lan Tianyu <Tianyu.Lan@xxxxxxxxxxxxx>

Looks good, but I'd like a second opinion. Guangrong, Junaid, can you
review this?


It looks good to me.

Reviewed-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxx>

BTW, the @intel box is not accessible to me now. ;)