Re: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback

[Alan Tull]

On Tue, Jul 24, 2018 at 9:17 AM, Appana Durga Kedareswara rao
<appana.durga.rao@xxxxxxxxxx> wrote:

Hi Appana,

Another minor thing.

> +
> +/****************************************************************************/

Let's keep the coding style consistent by not having
'***************************'

> +/**
> + *

Also, you don't need /** followed by '*', just take out the
essentially blank line here, please.

> + * Generates a Type 2 packet header that reads back the requested Configuration
> + * register.
> + *
> + * @param        OpCode is the read/write operation code.
> + * @param        Size is the size of the word to be read.
> + *
> + * @return       Type 2 packet header to read the specified register
> + *
> + * @note         None.
> + *
> + *****************************************************************************/
> +static int zynq_type2_pkt(u8 OpCode, u32 Size)
> +{

Thanks,
Alan