Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used

From: Sam Ravnborg
Date: Tue Jul 24 2018 - 10:55:32 EST


Hi Thomas.

> >
> > The SPARC way to format comments follows netdev style.
> > So put it all in one line and everyone are happy:
>
> Well, the code is being moved from arch/sparc to arch/sparc, so
> apparently, it was already non-compliant to this specific coding style
> rule. Should the comments be made compliant as part of the same commit,
> or a separate one ?
Same commit, no reason to slit this in two.
So post a v2, then everyone should be happy.

I also looked at the second patch which looked obviously correct.
Feel free to add my Ack on both.

Sam