RE: [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es

[Fang Hongjie(方洪杰)]

> mmc_select_hs400es() calls mmc_select_bus_width() which will continue
> to set 4bit transfer mode if fail to set 8bit mode. The bus width
> should not be set to 4bit in HS400es.
> 
> When fail to set 8bit mode, need return error directly for HS400es.
> 
> Signed-off-by: Hongjie Fang <hongjiefang@xxxxxxxxxxxx>
> ---
>  drivers/mmc/core/mmc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 4466f5d..0dbc512 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1338,8 +1338,12 @@ static int mmc_select_hs400es(struct mmc_card *card)
>  		goto out_err;
> 
>  	err = mmc_select_bus_width(card);
> -	if (err < 0)
> +	if (err != MMC_BUS_WIDTH_8) {
> +		pr_err("%s: switch to 8bit bus width failed, err:%d\n",
> +			mmc_hostname(host), err);
> +		err = -EIO;
>  		goto out_err;
> +	}
> 
>  	/* Switch card to HS mode */
>  	err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> --
> 1.9.1

Ping.
Any suggestion for it?

B&R
Hongjie