Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD

[Paolo Bonzini]

On 02/07/2018 18:34, Brijesh Singh wrote:
> 
> 
> On 06/27/2018 11:30 AM, Janakarajan Natarajan wrote:
>> Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
>> that AMD Secure Processor device driver will be built-in when KVM_AMD is
>> also built-in.
>>
>> v1->v2:
>> * Removed usage of 'imply' Kconfig option.
>> * Change patch commit message.
>>
>> Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")
>>
>> Cc: <stable@xxxxxxxxxxxxxxx> # 4.16.x
>> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@xxxxxxx>
>> ---
> 
> Reviewed-by: Brijesh Singh <brijesh.singh@xxxxxxx>
> 
> 
>> Â arch/x86/kvm/Kconfig | 2 +-
>> Â 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
>> index 92fd433..1bbec38 100644
>> --- a/arch/x86/kvm/Kconfig
>> +++ b/arch/x86/kvm/Kconfig
>> @@ -85,7 +85,7 @@ config KVM_AMD_SEV
>> ÂÂÂÂÂ def_bool y
>> ÂÂÂÂÂ bool "AMD Secure Encrypted Virtualization (SEV) support"
>> ÂÂÂÂÂ depends on KVM_AMD && X86_64
>> -ÂÂÂ depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
>> +ÂÂÂ depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
>> ÂÂÂÂÂ ---help---
>> ÂÂÂÂÂ Provides support for launching Encrypted VMs on AMD processors.
>> Â

Queued, thanks.

Paolo