Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for classifier flows

From: Maxime Chevallier
Date: Sat Jul 14 2018 - 07:20:52 EST


On Fri, 13 Jul 2018 18:13:43 +0200
Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> wrote:


>+static int mvpp2_dbgfs_flow_id_show(struct seq_file *s, void *unused)
>+{
>+ struct mvpp2_dbgfs_flow_entry *entry = s->private;
>+ struct mvpp2_cls_flow *f;
>+
>+ f = mvpp2_cls_flow_get(entry->flow);

This won't compile with commit
9cee8c437543 ("net: mvpp2: mvpp2_cls_flow_get() can be static")

I should have seen that missing static in the RSS series, now that
it's fixed I'll send a V2 of that debugfs series, to make that function
non static for the right reason this time.

Thanks,

Maxime