Re: [PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

From: Greg Kroah-Hartman
Date: Sat Jul 14 2018 - 02:33:43 EST


On Fri, Jul 13, 2018 at 10:58:06PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
>
> Return -ETIMEDOUT on timeouts.
>
> Don't need 64-bit sized retry count.
>
> Use msleep().
>
> Return immediately when condition hit.

Huge hint, when you have to list the different things you do in a patch,
that means it should be split up into smaller patches.

Please rework this patch series based on this. I'll stop reviewing them
now and wait for a new set of patches.

thanks,

greg k-h