Re: [PATCH net-next v2 5/7] net: mvneta: Allocate page for the descriptor

From: David Miller
Date: Fri Jul 13 2018 - 21:23:25 EST


From: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
Date: Fri, 13 Jul 2018 18:18:39 +0200

> -static int mvneta_rx_refill(struct mvneta_port *pp,
> - struct mvneta_rx_desc *rx_desc,
> - struct mvneta_rx_queue *rxq)
> -
> +/* Allocate page per descriptor */
> +static inline int mvneta_rx_refill(struct mvneta_port *pp,
> + struct mvneta_rx_desc *rx_desc,

Please do not use inline functions in foo.c files, let the compiler
decide.

Thank you.