Re: [RFC PATCH v2 18/27] x86/cet/shstk: Introduce WRUSS instruction

From: Yu-cheng Yu
Date: Fri Jul 13 2018 - 13:42:49 EST


On Thu, 2018-07-12 at 21:18 -0700, Dave Hansen wrote:
> On 07/12/2018 09:16 PM, Dave Hansen wrote:
> >
> > On 07/12/2018 07:21 PM, Andy Lutomirski wrote:
> > >
> > > I am tempted to suggest that the whole series not be merged until
> > > there are actual docs. Itâs not a fantastic precedent.
> > Do you mean Documentation or manpages, or are you talking about hardware
> > documentation?
> > https://software.intel.com/sites/default/files/managed/4d/2a/control-flow-enforcement-technology-preview.pdf
> Hit send too soon...
>
> We do need manpages a well.ÂÂIf I had to do it for protection keys,
> everyone else has to suffer too. :)
>
> Yu-cheng, I really do think selftests are a necessity before this gets
> merged.
>

We already have some. ÂI will put those in patches.

Yu-cheng