Re: [PATCH v3 1/2] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

From: Stephen Boyd
Date: Fri Jul 13 2018 - 12:00:24 EST


Quoting Matthias Kaehlcke (2018-07-09 14:25:21)
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index 92bed1e7d4bb..7eea94701b23 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -11,6 +11,13 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pm8998_temp: temp-alarm@2400 {

Are we sorting this file based on node name or unit address? Otherwise
patch looks good.

> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0x2400>;
> + interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> pm8998_gpio: gpios@c000 {
> compatible = "qcom,pm8998-gpio", "qcom,spmi-gpio";
> reg = <0xc000>;