On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote:
This is mostly good, just a couple of small things:
+config SPI_AT91_USART
+ tristate "Atmel USART Controller SPI driver"
+ depends on HAS_DMA
+ depends on (ARCH_AT91 || COMPILE_TEST)
+ select MFD_AT91_USART
Why is this selecting rather than depending on the MFD like we normally
do?
@@ -0,0 +1,432 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Driver for AT91 USART Controllers as SPI
+ *
+ * Copyright (C) 2018 Microchip Technology Inc.
+ * Author: Radu Pirea <radu.pirea@xxxxxxxxxxxxx>
+ */
Please use C++ comments for the whole block so it looks a bit more
intentional.
Otherwise
Reviwed-by: Mark Brown <broonie@xxxxxxxxxx>