Re: [PATCH 03/10] atmel: hide unused procfs helpers

From: YueHaibing
Date: Fri Jul 13 2018 - 05:31:49 EST


pls ignore this,my bad.

On 2018/7/13 14:46, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/net/wireless/atmel/atmel.c:1402:12: warning: âatmel_proc_showâ defined but not used [-Wunused-function]
> static int atmel_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/net/wireless/atmel/atmel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c
> index b01dc34..3940876 100644
> --- a/drivers/net/wireless/atmel/atmel.c
> +++ b/drivers/net/wireless/atmel/atmel.c
> @@ -1399,6 +1399,7 @@ static int atmel_validate_channel(struct atmel_private *priv, int channel)
> return 0;
> }
>
> +#ifdef CONFIG_PROC_FS
> static int atmel_proc_show(struct seq_file *m, void *v)
> {
> struct atmel_private *priv = m->private;
> @@ -1481,6 +1482,7 @@ static int atmel_proc_show(struct seq_file *m, void *v)
> seq_printf(m, "Current state:\t\t%s\n", s);
> return 0;
> }
> +#endif
>
> static const struct net_device_ops atmel_netdev_ops = {
> .ndo_open = atmel_open,
>