Re: [PATCH v4 13/14] rxrpc: Prepare to remove VLA usage for SKCIPHER_REQUEST_ON_STACK

From: Kees Cook
Date: Thu Jul 12 2018 - 17:38:41 EST


On Thu, Jul 12, 2018 at 2:15 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Thu, Jul 12, 2018 at 10:30 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> Actually, I think this can actually be adjusted to just re-use the
>> stack allocation, since rxkad_verify_packet() finishes one before
>> doing another in rxkad_verify_packet_1():
>
> That looks very nice, yes. The same thing is needed in
> rxkad_secure_packet(), right?

Yup. 4 leaf functions and the 2 callers.

-Kees

--
Kees Cook
Pixel Security