Re: [PATCH v9 4/7] tracepoint: Make rcuidle tracepoint callers use SRCU

From: Steven Rostedt
Date: Thu Jul 12 2018 - 16:15:45 EST


On Thu, 12 Jul 2018 12:17:01 -0700
Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:

> AFAICT, _notrace doesn't call into lockdep or tracing (there's also a comment
> that says so):
>
> /**
> * srcu_dereference_notrace - no tracing and no lockdep calls from here
> */

Note, I had a different tree checked out, so I didn't have the source
available without digging through my email.

>
> So then, we should use the regular variant for this additional check you're
> suggesting.

OK, I thought we had a rcu_dereference_notrace() that did checks and
thought that this followed suit, but it appears there is no such call.
That's where my confusion was.

Sure, I'll nuke the notrace() portion, thanks.

Also, I've applied 1-3, since 4 and 5 looks to be getting a remake, I'm
going to remove them from my queue. Please fold the SPDX patch into 5.

Thanks!

-- Steve