Re: [PATCH v2 3/7] soc/tegra: pmc: Implement tegra_io_pad_is_powered()

From: Jon Hunter
Date: Thu Jul 12 2018 - 06:10:15 EST



On 12/07/18 08:52, Aapo Vienamo wrote:
> On Wed, 11 Jul 2018 16:26:42 +0100
> Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
>> On 11/07/18 16:23, Jon Hunter wrote:
>>>
>>> On 11/07/18 15:01, Aapo Vienamo wrote:
>>>> Implement a function to query whether a pad is in deep power down mode.
>>> Can you elaborate on why this public function is needed and who will be
>>> using this?
>>
>> Or I should say does this need to be public?
>
> It's only called from the pinconf callbacks and exposing it doesn't
> indeed make much sense if we intend to replace direct calls to pmc.c
> with pinctrl anyway. I'll make it private on the next iteration of the
> series.

Yes let's make it private.

Cheers
Jon

--
nvpublic