Re: [PATCH] powerpc: Replaced msleep(x) with msleep(OPAL_BUSY_DELAY_MS)
From: Michael Ellerman
Date: Thu Jul 12 2018 - 01:46:20 EST
Daniel Klamt <eleon@xxxxxxxx> writes:
> Replaced msleep(x) with with msleep(OPAL_BUSY_DELAY_MS)
> to diocument these sleep is to wait for opal.
>
> Signed-off-by: Daniel Klamt <eleon@xxxxxxxx>
> Signed-off-by: Bjoern Noetel <bjoern@xxxxxxxxxx>
Thanks.
Your change log should be in the imperative mood, see:
https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133
In this case that just means saying "Replace" rather than "Replaced".
Also the prefix should be "powerpc/xive". You can guess that by doing:
$ git log --oneline arch/powerpc/sysdev/xive/native.c
And notice that the majority of commits use that prefix.
I've fixed both of those things up for you.
cheers