Re: [PATCH] extcon: max3355: include mod_devicetable.h

[Randy Dunlap]

On 07/11/2018 08:50 AM, Arnd Bergmann wrote:
> Another driver turned up that is missing linux/mod_devicetable.h after
> the device IDs are split out from linux/platform_device.h:
> 
> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
>  static const struct of_device_id max3355_match_table[] = {
> 
> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Sorry for the delay.  I've been traveling.
And Thanks.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

> ---
> Greg, please add that to the char-misc tree that already has
> other related patches.
> ---
>  drivers/extcon/extcon-max3355.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
> index 0aa410836f4e..1335a476bfec 100644
> --- a/drivers/extcon/extcon-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/interrupt.h>
>  #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  
>  struct max3355_data {
> 


-- 
~Randy