Re: [PATCH v35 1/5] mm: support to get hints of free page blocks

From: Wei Wang
Date: Wed Jul 11 2018 - 22:17:54 EST


On 07/12/2018 12:23 AM, Linus Torvalds wrote:
On Wed, Jul 11, 2018 at 2:21 AM Michal Hocko <mhocko@xxxxxxxxxx> wrote:
We already have an interface for that. alloc_pages(GFP_NOWAIT, MAX_ORDER -1).
So why do we need any array based interface?
That was actually my original argument in the original thread - that
the only new interface people might want is one that just tells how
many of those MAX_ORDER-1 pages there are.

See the thread in v33 with the subject

"[PATCH v33 1/4] mm: add a function to get free page blocks"

and look for me suggesting just using

#define GFP_MINFLAGS (__GFP_NORETRY | __GFP_NOWARN |
__GFP_THISNODE | __GFP_NOMEMALLOC)

Would it be better to remove __GFP_THISNODE? We actually want to get all the guest free pages (from all the nodes).

Best,
Wei