Re: [PATCH] kernel.h: Add for_each_if()
From: Andrew Morton
Date: Wed Jul 11 2018 - 19:06:02 EST
On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter <daniel@xxxxxxxx> wrote:
> But I still have the situation that a bunch of maintainers acked this
> and Andrew Morton defacto nacked it, which I guess means I'll keep the
> macro in drm? The common way to go about this seems to be to just push
> the patch series with the ack in some pull request to Linus and ignore
> the people who raised questions, but not really my thing.
Heh.
But, am I wrong? Code which uses regular kernel style doesn't have
these issues. We shouldn't be enabling irregular style - we should be
making such sites more regular. The fact that the compiler generates a
nice warning in some cases simply helps us with that.