Re: [PATCH net-next 1/2] tcp: remove redundant rcv_nxt update

From: Eric Dumazet
Date: Wed Jul 11 2018 - 13:01:23 EST




On 07/11/2018 06:16 AM, Yafang Shao wrote:
> tcp_rcv_nxt_update() is already executed in tcp_data_queue().
> This line is redundant.
>
> See bellow,
> tcp_queue_rcv
> tcp_rcv_nxt_update(tcp_sk(sk), TCP_SKB_CB(skb)->end_seq);
> tcp_rcv_nxt_update(tp, TCP_SKB_CB(skb)->end_seq); <<<< redundant
>
> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> ---

This patch is fine (but not the following)

Signed-off-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Thanks.