Re: [PATCH v9 4/7] tracepoint: Make rcuidle tracepoint callers use SRCU

From: Mathieu Desnoyers
Date: Wed Jul 11 2018 - 12:46:50 EST


----- On Jul 11, 2018, at 11:26 AM, rostedt rostedt@xxxxxxxxxxx wrote:

> On Wed, 11 Jul 2018 17:17:51 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
>> I just read the comment that goes with that function; the order doesn't
>> matter. All we want to ensure is that the unregistration is visible to
>> either sched or srcu tracepoint users.
>
> Yeah, but I think it is still good to change the order. It doesn't
> hurt, and in my opinion makes the code a bit more robust.

I don't mind. It makes the code more regular. It does not change
anything wrt robustness here though.

Thanks,

Mathieu


--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com