Re: [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC

[Jian Hu]

On 2018/7/10 5:57, Martin Blumenstingl wrote:
> adding Rob Herring so it doesn't get lost on the devicetree mailing list
>
> On Mon, Jul 9, 2018 at 1:13 PM Jian Hu <jian.hu@xxxxxxxxxxx> wrote:
> > Add new binding for Meson-G12A SoC Everything-Else part
> >
> > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > index e950599..0833006 100644
> > --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
> > @@ -9,6 +9,7 @@ Required Properties:
> >                  "amlogic,gxbb-clkc" for GXBB SoC,
> >                  "amlogic,gxl-clkc" for GXL and GXM SoC,
> >                  "amlogic,axg-clkc" for AXG SoC.
> > +               "amlogic,g12a-clkc" for G12A SoC.
> should this be "amlogic,meson-g12a-clkc" instead?
> that would make it consistent with virtually all other bindings which
> use the schema "amlogic,meson<chip>-<ip-block>" (where chip is 8, 8b,
> 8m2, -gxbb, -gxl, ...)
>
> see also: $ grep -R "amlogic," Documentation/devicetree/bindings/
Which type should we choose,have a discussion?
.compatible = "amlogic,g12a-clkc or
.compatible = "amlogic,meson-g12a-clkc
> >   - #clock-cells: should be 1.
> >
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-amlogic mailing list
> > linux-amlogic@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
> .