çå: çå: [PATCH v5 1/1] PCI: kirin: Add MSI support

[Songxiaowei (Kirin_DRV)]

> -----éäåä-----
> åää: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@xxxxxxx]
> åéæé: 2018å7æ10æ 23:40
> æää: Songxiaowei (Kirin_DRV) <songxiaowei@xxxxxxxxxxxxx>
> æé: bhelgaas@xxxxxxxxxx; robh+dt@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; chenyao (F) <chenyao11@xxxxxxxxxx>
> äé: Re: çå: [PATCH v5 1/1] PCI: kirin: Add MSI support
> 
> On Mon, Jul 09, 2018 at 01:54:07AM +0000, Songxiaowei (Kirin_DRV) wrote:
> > Hi Bjorn Helgaas,
> >
> > Would you help to review this patch?
> >
> > Best regards,
> >
> > Xiaowei.
> >
> > > -----éäåä-----
> > > åää: Songxiaowei (Kirin_DRV)
> > > åéæé: 2018å6æ28æ 20:48
> > > æää: Wangbinghui <wangbinghui@xxxxxxxxxxxxx>;
> bhelgaas@xxxxxxxxxx;
> > > robh+dt@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> > > robh+linux-kernel@xxxxxxxxxxxxxxx;
> > > dimitrysh@xxxxxxxxxx
> > > æé: chenyao (F) <chenyao11@xxxxxxxxxx>; Songxiaowei (Kirin_DRV)
> > > <songxiaowei@xxxxxxxxxxxxx>
> > > äé: [PATCH v5 1/1] PCI: kirin: Add MSI support
> > >
> > > Add support for MSI.
> > >
> > > Signed-off-by: Xiaowei Song <songxiaowei@xxxxxxxxxxxxx>
> > > ---
> > >  drivers/pci/dwc/pcie-kirin.c | 28 ++++++++++++++++++++++++++++
> > >  1 file changed, 28 insertions(+)
> > >
> > > diff --git a/drivers/pci/dwc/pcie-kirin.c
> > > b/drivers/pci/dwc/pcie-kirin.c index d2970a009eb5..6997276eb69c
> > > 100644
> > > --- a/drivers/pci/dwc/pcie-kirin.c
> > > +++ b/drivers/pci/dwc/pcie-kirin.c
> > > @@ -430,6 +430,9 @@ static int kirin_pcie_host_init(struct pcie_port
> > > *pp) {
> > >  	kirin_pcie_establish_link(pp);
> > >
> > > +	if (IS_ENABLED(CONFIG_PCI_MSI))
> > > +		dw_pcie_msi_init(pp);
> > > +
> > >  	return 0;
> > >  }
> > >
> > > @@ -445,9 +448,34 @@ static const struct dw_pcie_host_ops
> > > kirin_pcie_host_ops = {
> > >  	.host_init = kirin_pcie_host_init,  };
> > >
> > > +static int kirin_pcie_add_msi(struct dw_pcie *pci,
> > > +				struct platform_device *pdev)
> > > +{
> > > +	int ret = 0;
> > > +
> > > +	if (IS_ENABLED(CONFIG_PCI_MSI)) {
> > > +		ret = platform_get_irq(pdev, 0);
> > > +		if (ret < 0) {
> > > +			dev_err(&pdev->dev,
> > > +				"failed to get MSI IRQ (%d)\n", ret);
> > > +			return ret;
> > > +		}
> > > +
> > > +		pci->pp.msi_irq = ret;
> > > +	}
> > > +
> > > +	return ret;
> > > +}
> > > +
> > >  static int __init kirin_add_pcie_port(struct dw_pcie *pci,
> > >  				      struct platform_device *pdev)  {
> > > +	int ret;
> > > +
> > > +	ret = kirin_pcie_add_msi(pci, pdev);
> > > +	if (ret)
> > > +		return ret;
> 
> If kirin_pcie_add_msi() returns an IRQ number we return from this function
> here, is that what you really want ?
[songxiaowei]  Sorry about this issue, I'll check the patch carefully and test it on Hikey960 Board.
			 Thanks a lot for your time.

Best regards,
Xiaowei.
> 
> Lorenzo
> 
> > > +
> > >  	pci->pp.ops = &kirin_pcie_host_ops;
> > >
> > >  	return dw_pcie_host_init(&pci->pp);
> > > --
> > > 2.11.GIT
> >