Re: [PATCH] 9p/net/protocol.c: return -ENOMEM when kmalloc() failed

[jiangyiwen]

On 2018/7/11 8:43, piaojun wrote:
> We should return -ENOMEM to upper user when kmalloc failed to indicate
> accurate errno.
> 
> Signed-off-by: Jun Piao <piaojun@xxxxxxxxxx>

Reviewed-by: Yiwen Jiang <jiangyiwen@xxxxxxxxxx>

> ---
>  net/9p/protocol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/9p/protocol.c b/net/9p/protocol.c
> index 931ea00..4a1e1dd 100644
> --- a/net/9p/protocol.c
> +++ b/net/9p/protocol.c
> @@ -156,7 +156,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size)
> 
>  				*sptr = kmalloc(len + 1, GFP_NOFS);
>  				if (*sptr == NULL) {
> -					errcode = -EFAULT;
> +					errcode = -ENOMEM;
>  					break;
>  				}
>  				if (pdu_read(pdu, *sptr, len)) {
>